Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make surface.init compatible with phx_new 1.7.14 #753

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Make surface.init compatible with phx_new 1.7.14 #753

merged 2 commits into from
Oct 1, 2024

Conversation

tiagoefmoraes
Copy link
Member

Only changes required were on 1.7.10 -> 1.7.11 upgrade.

hooks in assets/js/app.js
image

esbuild config in config/config.exs
image

@tiagoefmoraes tiagoefmoraes self-assigned this Sep 28, 2024
msaraiva
msaraiva approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@msaraiva msaraiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜

@tiagoefmoraes tiagoefmoraes merged commit 0519ab0 into main Oct 1, 2024
7 checks passed
@tiagoefmoraes tiagoefmoraes deleted the update_surface.init branch October 1, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaraiva msaraiva msaraiva approved these changes

Assignees

@tiagoefmoraes tiagoefmoraes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiagoefmoraes @msaraiva