Auth methods #19
Open
Auth methods #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and provides ability to define scope, ns, db etc
This will allow us to do individual tests without re-creating db each time Wrote tests for `SignupUser` & `SigninUser`
|
Hey @iDevelopThings ! Thanks for creating this - would it be possible to resolve the conflicts please? To make it easier to review. Thanks! |
|
Hey @iDevelopThings gentle ping, can you fix the merge conflicts so that we can go ahead and review the PR? |
|
Hey @iDevelopThings! Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found my self adding these changes into my project, so decided I'd update this PR with them instead ^^
Mainly signin/signup will return a token if you sign up a user via a scope for example
I'm also not sure if this will add commits to #17 or create a new PR, either way it includes those changes too.