Fixed f-tests and updated etalons

surveyjs · Nov 13, 2024 · 5721654 · 5721654
1 parent 9263540
commit 5721654
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 5 deletions.
diff --git a/packages/survey-creator-angular/src/row.component.ts b/packages/survey-creator-angular/src/row.component.ts
@@ -24,6 +24,7 @@ export class CreatorRowComponent extends CreatorModelComponent<RowViewModel> {
   }
   createModel() {
     this.model = new RowViewModel(this.creator, this.row, <any>undefined);
+    this.model.subscribeElementChanges();
   }
   getPropertiesToTrack(): string[] {
     return ["creator", "row"];

diff --git a/packages/survey-creator-knockout/src/row.ts b/packages/survey-creator-knockout/src/row.ts
@@ -22,6 +22,7 @@ class KnockoutRowViewModel extends RowViewModel {
     public templateData: any
   ) {
     super(creator, row, templateData);
+    this.subscribeElementChanges();
   }
 }
 

diff --git a/packages/survey-creator-vue/src/tabs/designer/Row.vue b/packages/survey-creator-vue/src/tabs/designer/Row.vue
@@ -9,7 +9,7 @@
 import { useCreatorModel } from "@/creator-model";
 import type { QuestionRowModel } from "survey-core";
 import { SurveyCreatorModel, RowViewModel } from "survey-creator-core";
-import { computed } from "vue";
+import { computed, onMounted, onUnmounted } from "vue";
 
 const props = defineProps<{
   componentData: { creator: SurveyCreatorModel; row: QuestionRowModel };
@@ -25,4 +25,12 @@ const model = useCreatorModel(
     value.dispose();
   }
 );
+
+onMounted(() => {
+  model.subscribeElementChanges();
+});
+onUnmounted(() => {
+  model.unsubscribeElementChanges();
+});
+
 </script>
diff --git a/visualRegressionTests-V2/tests/designer/surface.ts b/visualRegressionTests-V2/tests/designer/surface.ts
@@ -68,7 +68,7 @@ test("Test question type converter", async (t) => {
     await takeElementScreenshot("convert-to-popup.png", Selector(".sv-popup__container").filterVisible(), t, comparer);
   });
 });
-test("Test question type converter on page for panel", async (t) => {
+test("Test question type converter on page for panel - 1", async (t) => {
   await wrapVisualTest(t, async (t, comparer) => {
     await t.resizeWindow(1000, 800);
 
@@ -97,7 +97,7 @@ test("Test question type converter on page for panel", async (t) => {
   });
 });
 
-test("Test question type converter on page for panel", async (t) => {
+test("Test question type converter on page for panel - 2", async (t) => {
   await wrapVisualTest(t, async (t, comparer) => {
     await t.resizeWindow(1000, 800);
 

diff --git a/visualRegressionTests/tests/designer/etalons/convert-to-popup-panel-not-empty.png b/visualRegressionTests/tests/designer/etalons/convert-to-popup-panel-not-empty.png
diff --git a/visualRegressionTests/tests/designer/etalons/convert-to-popup-panel.png b/visualRegressionTests/tests/designer/etalons/convert-to-popup-panel.png
diff --git a/visualRegressionTests/tests/designer/surface.ts b/visualRegressionTests/tests/designer/surface.ts
@@ -68,7 +68,7 @@ test("Test question type converter", async (t) => {
     await takeElementScreenshot("convert-to-popup.png", Selector(".sv-popup__container").filterVisible(), t, comparer);
   });
 });
-test("Test question type converter on page for panel", async (t) => {
+test.only("Test question type converter on page for panel - 1", async (t) => {
   await wrapVisualTest(t, async (t, comparer) => {
     await t.resizeWindow(1000, 800);
 
@@ -97,7 +97,7 @@ test("Test question type converter on page for panel", async (t) => {
   });
 });
 
-test("Test question type converter on page for panel", async (t) => {
+test.only("Test question type converter on page for panel - 2", async (t) => {
   await wrapVisualTest(t, async (t, comparer) => {
     await t.resizeWindow(1000, 800);
-Original file line number
+Diff line change
@@ Expand Up / @@ -22,6 +22,7 @@ class KnockoutRowViewModel extends RowViewModel { @@
         public templateData: any
       ) {
         super(creator, row, templateData);
+        this.subscribeElementChanges();
       }
     }
@@ Expand Down @@