Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat super linter #142

Merged
merged 40 commits into from
Apr 6, 2024

Conversation

maryamtahhan
Copy link
Contributor

@maryamtahhan maryamtahhan commented Apr 2, 2024

  • Update super linter version to latest
  • Fix markdown issues in existing docs
  • Fix Typos in existing docs

@maryamtahhan
Copy link
Contributor Author

I have a few more small updates to sort out tomorrow morning before moving from Draft PR -> PR. Will push an update tomorrow.

@maryamtahhan maryamtahhan marked this pull request as ready for review April 3, 2024 09:23
@Shobhij
Copy link
Contributor

Shobhij commented Apr 3, 2024

Hi Maryam, Looks like my one wrong github command signed me off against other people commits :P and while trying to solve the I messed up my pull request #139. Just wondering could you please help me here or point me towards the command which can be help me to open the same pull request again? As far as i know I was able to remove my sign off from other people's commit. But, it closed my pull request. :(

@maryamtahhan
Copy link
Contributor Author

@rootfs can you please have a quick look. The idea behind this PR is to make existing Markdown docs compliant with the super linter rules.

docs/design/metrics.md Show resolved Hide resolved
docs/design/metrics.md Show resolved Hide resolved
docs/design/metrics.md Show resolved Hide resolved
docs/design/metrics.md Show resolved Hide resolved
docs/design/metrics.md Show resolved Hide resolved
@rootfs
Copy link
Contributor

rootfs commented Apr 4, 2024

@maryamtahhan can you rebase? thanks!

sunya-ch and others added 16 commits April 5, 2024 10:21
Signed-off-by: Sunyanan Choochotkaew <[email protected]>
Signed-off-by: Maryam Tahhan <[email protected]>
Signed-off-by: Maryam Tahhan <[email protected]>
@rootfs rootfs merged commit abc7edb into sustainable-computing-io:main Apr 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants