Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Helm Installation Instructions #145

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

marvin-steinke
Copy link

  • added helm Prometheus setup for users new to K8s who are not familiar with Prometheus Node Exporter which needs to be installed for Kepler to work. I recommend the installation of the kube-prometheus-stack.
  • clarified the usage of the serviceMonitor for the Kepler charts: The value serviceMonitor.enabled needs to be set to true and the value serviceMonitor.labels.release needs to be set to the release name of the kube-prometheus-stack installtion.
  • added some convenient post install instructions, also aimed at newer users.
  • added chinese version of this docs, translated by gpt-4. This is probably very wrong and should only serve as a draft for someone who speaks the language ^^

@marvin-steinke marvin-steinke changed the title Updated Helm Installtion Instructions Updated Helm Installation Instructions Apr 4, 2024
@rootfs
Copy link
Contributor

rootfs commented Apr 4, 2024

@marvin-steinke thanks! can you sign DCO

Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
In your local branch, run: git rebase HEAD~2 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin main

@rootfs rootfs requested a review from SamYuan1990 April 4, 2024 18:13
Copy link
Contributor

@SamYuan1990 SamYuan1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try to have a link to prometheus install steps? Honestly I am not sure if we should cover prometheus steps in our document.... which means for any update on prometheus we should have an update ...

Signed-off-by: marvin.steinke <[email protected]>
Signed-off-by: Marvin Steinke <[email protected]>
Signed-off-by: marvin.steinke <[email protected]>
Signed-off-by: Marvin Steinke <[email protected]>
@marvin-steinke
Copy link
Author

Can we try to have a link to prometheus install steps? Honestly I am not sure if we should cover prometheus steps in our document.... which means for any update on prometheus we should have an update ...

I'm afraid I don't know how to install the Kepler helm package for a non-helm prometheus installation regarding the release label that has to be set. Because of this I included specific instructions for a full helm install. The only way installation instructions for the kube-prometheus-stack are going to change is if the repository stops to exists in which case we would have to link another helm chart anyways, right?

@SamYuan1990
Copy link
Contributor

Can we try to have a link to prometheus install steps? Honestly I am not sure if we should cover prometheus steps in our document.... which means for any update on prometheus we should have an update ...

I'm afraid I don't know how to install the Kepler helm package for a non-helm prometheus installation regarding the release label that has to be set. Because of this I included specific instructions for a full helm install. The only way installation instructions for the kube-prometheus-stack are going to change is if the repository stops to exists in which case we would have to link another helm chart anyways, right?

ok, please go ahead to complete this PR and notify me after it's ready for review :-)

@marvin-steinke marvin-steinke marked this pull request as ready for review April 5, 2024 13:12
@rootfs rootfs merged commit dada268 into sustainable-computing-io:main Apr 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants