Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local-cluster.md #159

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

ChrisChinchilla
Copy link
Contributor

The current code snippet is missing things to make it workable.

@ChrisChinchilla
Copy link
Contributor Author

I also don't think the make cluster-up command mentioned will do anything, but maybe I missed something

@SamYuan1990
Copy link
Contributor

thanks @ChrisChinchilla , could you please follow up https://github.com/sustainable-computing-io/kepler-doc/pull/159/checks?check_run_id=26601781901 to sign your commit as we enabled DCO check.

@ChrisChinchilla
Copy link
Contributor Author

Yeah sorry I think it's because I did it through the GitHub ui. Will need to clone the repo etc to do it. Will do it asap

The current code snippet is missing things to make it workable.

Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Copy link
Contributor Author

@SamYuan1990 Done

Copy link
Contributor

@SamYuan1990 SamYuan1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamYuan1990 SamYuan1990 merged commit bc70456 into sustainable-computing-io:main Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants