-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): enhance OpenShift dashboard #247
feat(dashboard): enhance OpenShift dashboard #247
Conversation
488694e
to
9ea4e02
Compare
Quick question can we add units to the panel value like Watt or Killowatt? For eg. In the case of |
9ea4e02
to
309af88
Compare
@vprashar2929 yes, I added the units in the total energy consumption panel. Unfortunately other panels, like tables and line charts are limited on that |
@jgbernalp can we sort the top10 namespace table by values? |
309af88
to
79cf758
Compare
@vimalk78 this is a known limitation, by default the table content is sorted based on the first column values, the values can be sorted clicking on the table header. I understand it will be important to sort so the user gets proper information. We could potentially raise this as a bug. |
@jgbernalp Also can you move |
79cf758
to
b7b4ecb
Compare
@vprashar2929 yes makes sense, i've moved them. |
With regards to Phase 1 of this initiative, looks good to me. Thanks! |
Signed-off-by: Gabriel Bernal <[email protected]>
b7b4ecb
to
3f0b476
Compare
Just one comment about moving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgbernalp could you please rename the file to powermon-dashboard-namespace.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgbernalp,
For the PR to pass CI, we need to rename this to powermon-dashboard-overview.json
and also update the
https://github.com/sustainable-computing-io/kepler-operator/blob/v1alpha1/pkg/components/exporter/exporter.go#L87 to use this file.
I will then create a follow-up PR that deploys both dashboards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes were included by #258 |
Fixes: #246
https://issues.redhat.com/browse/OU-250
Screen.Recording.2023-09-25.at.14.45.40.mov