Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): enhance OpenShift dashboard #247

Conversation

jgbernalp
Copy link
Contributor

Fixes: #246

https://issues.redhat.com/browse/OU-250

Screen.Recording.2023-09-25.at.14.45.40.mov

@jgbernalp jgbernalp force-pushed the enhance-openshift-dashboard branch from 488694e to 9ea4e02 Compare September 25, 2023 13:12
@vprashar2929
Copy link
Collaborator

Quick question can we add units to the panel value like Watt or Killowatt? For eg. In the case of Total Energy Consumption panel the value we get is in Killowatt-hour

@jgbernalp jgbernalp force-pushed the enhance-openshift-dashboard branch from 9ea4e02 to 309af88 Compare September 25, 2023 14:46
@jgbernalp
Copy link
Contributor Author

@vprashar2929 yes, I added the units in the total energy consumption panel. Unfortunately other panels, like tables and line charts are limited on that

@jgbernalp
Copy link
Contributor Author

Screenshot 2023-09-25 at 16 47 06

@vimalk78
Copy link
Collaborator

@jgbernalp can we sort the top10 namespace table by values?

@jgbernalp jgbernalp force-pushed the enhance-openshift-dashboard branch from 309af88 to 79cf758 Compare September 25, 2023 16:01
@jgbernalp
Copy link
Contributor Author

jgbernalp commented Sep 25, 2023

@vimalk78 this is a known limitation, by default the table content is sorted based on the first column values, the values can be sorted clicking on the table header. I understand it will be important to sort so the user gets proper information. We could potentially raise this as a bug.

@vprashar2929
Copy link
Collaborator

@jgbernalp Also can you move Total Power Consumption (W) in Namespace and Total Power Consumption (kWh per day) in Namespace panels below Total Power Consumption for Top 10 Namespaces (kWh per day)? Since these represent the aggregate power consumption I think it's better to put them first rather than bottom. Wdyt?

@jgbernalp jgbernalp force-pushed the enhance-openshift-dashboard branch from 79cf758 to b7b4ecb Compare September 25, 2023 16:52
@jgbernalp
Copy link
Contributor Author

@vprashar2929 yes makes sense, i've moved them.

@fkargbo
Copy link

fkargbo commented Sep 27, 2023

With regards to Phase 1 of this initiative, looks good to me. Thanks!

@jgbernalp
Copy link
Contributor Author

As discussed in our meeting of Sep 28th

  • I split the dashboards into 2: Namespace and Overview
  • Adjust the names on the overview panels to add the last 24 hours info
  • Removed the total Kepler nodes as the info was duplicated
Screenshot 2023-09-28 at 11 27 16 Screenshot 2023-09-28 at 11 26 46 Screenshot 2023-09-28 at 11 26 35

@jgbernalp jgbernalp force-pushed the enhance-openshift-dashboard branch from b7b4ecb to 3f0b476 Compare September 28, 2023 12:10
@vprashar2929
Copy link
Collaborator

Just one comment about moving Total Power Consumption (W) in Namespace and Total Power Consumption (kWh per day) in Namespace panels to the top in kepler-dashboard-namespace.json

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgbernalp could you please rename the file to powermon-dashboard-namespace.json

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgbernalp,
For the PR to pass CI, we need to rename this to powermon-dashboard-overview.json and also update the
https://github.com/sustainable-computing-io/kepler-operator/blob/v1alpha1/pkg/components/exporter/exporter.go#L87 to use this file.

I will then create a follow-up PR that deploys both dashboards.

Copy link
Collaborator

@sthaha sthaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgbernalp
Copy link
Contributor Author

Changes were included by #258

@jgbernalp jgbernalp closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance OpenShift dashboard for Kepler
5 participants