test: Add error check during cleanup #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthaha
reviewed
Sep 27, 2023
tests/e2e/kepler_test.go
Outdated
| @@ -88,7 +93,8 @@ func TestNodeSelector(t *testing.T) { | |||
| err = f.AddResourceLabels("node", node, labels) | |||
| assert.NoError(t, err, "could not label node") | |||
| t.Cleanup(func() { | |||
There was a problem hiding this comment.
@vprashar2929 thanks for the patch. Since you are at it, could you also please move t.Cleanup to f.AddResourceLabels itself. There are other functions in the framework that automatically cleans up after itself so that the caller need not worry about cleaning up.
vprashar2929
force-pushed
the
update-e2e
branch
from
fd1faf6 to
041b4ea
Compare
sthaha
reviewed
Sep 28, 2023
tests/e2e/kepler_test.go
Outdated
Comment on lines
134
to
138
| t.Cleanup(func() { | ||
| // remove taint | ||
| f.TaintNode(node, fmt.Sprintf("%s-", e2eTestTaint.Key)) | ||
| err := f.TaintNode(node, fmt.Sprintf("%s-", e2eTestTaint.Key)) | ||
| assert.NoError(t, err, "could not remove taint from node") | ||
| }) |
There was a problem hiding this comment.
Thanks a lot for the fix above.. can we do the same here 🙏 ?
There was a problem hiding this comment.
@vprashar2929 may be in a followup PR?
There was a problem hiding this comment.
Completely forgot this😅 I will fix this as well in the PR
sthaha
previously approved these changes
Sep 28, 2023
tests/e2e/kepler_test.go
Outdated
Comment on lines
134
to
138
| t.Cleanup(func() { | ||
| // remove taint | ||
| f.TaintNode(node, fmt.Sprintf("%s-", e2eTestTaint.Key)) | ||
| err := f.TaintNode(node, fmt.Sprintf("%s-", e2eTestTaint.Key)) | ||
| assert.NoError(t, err, "could not remove taint from node") | ||
| }) |
There was a problem hiding this comment.
@vprashar2929 may be in a followup PR?
Signed-off-by: Vibhu Prashar <[email protected]>
vprashar2929
force-pushed
the
update-e2e
branch
from
041b4ea to
4d07048
Compare
sthaha
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the check for any error in the case when cleanup happens.