chore(ci): remove space reclamation steps for GH runners #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthaha
reviewed
Oct 25, 2024
.github/workflows/pr-checks.yaml
Outdated
| @@ -165,7 +165,7 @@ jobs: | |||
| - name: Run Operator Upgrade | |||
| shell: bash | |||
| run: | | |||
| ./tests/run-e2e.sh --ci | |||
| ./tests/run-e2e.sh | |||
There was a problem hiding this comment.
Lets preserve --ci since the flag can be used to decide on other things than run container rm later.
sthaha
reviewed
Oct 25, 2024
.github/workflows/pr-checks.yaml
Outdated
| - name: Run e2e tests | ||
| run: | | ||
| ./tests/run-e2e.sh --ci --no-upgrade | ||
| ./tests/run-e2e.sh --no-upgrade |
There was a problem hiding this comment.
same here .. lets keep --ci 🙏
sthaha
requested changes
Oct 25, 2024
vprashar2929
force-pushed
the
chore-ci-space
branch
from
addf442 to
4da4a29
Compare
This commit removes the steps previously used to reclaim space on GH runners. Since we have moved to self-hosted runners with more resources available, these steps are no longer necessary Signed-off-by: vprashar2929 <[email protected]>
sthaha
force-pushed
the
chore-ci-space
branch
from
4da4a29 to
38a4cfa
Compare
sthaha
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the steps previously used to reclaim space on GH runners. Since we have moved to self-hosted runners with more resources available, these steps are no longer necessary
Addresses: #429