Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force custom translation if any before parse checks #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vanilsonbr
Copy link

@vanilsonbr vanilsonbr commented Jul 5, 2020

Force the custom translation defined by the user before perfoming other checks.

There are some problems when the user tries to custom translate an C# Array to a javascript type.
I've trying to custom translate byte[] to string, but it ended up translating it to string[].

I had similar problems trying to translate Model[] to AnotherModel[].
My config-file.json at "customTypeTranslations" was sometinh like this:

{
  "byte[]": "string",
  "Model[]": "AnotherModel[]"
}

In this case, I'm assuming that the dev knows what he's doing when he, by adding a custom translation, chooses to translate, for example, and array of Model to an array of AnotherModel.

Closes #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom type Translation from byte[] isn't working
1 participant