Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to-json-type #248

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Fix to-json-type #248

merged 4 commits into from
Dec 5, 2024

Conversation

svilupp
Copy link
Owner

@svilupp svilupp commented Dec 4, 2024

  • Removed unnecessary printing to stdout during precompilation in precompile.jl.
  • Fixed a "bug-waiting-to-happen" in tool use. to_json_type now enforces users to provide concrete types, because abstract types cannot be deserialized by JSON3.
  • Flowed through a bug fix in StreamCallback where the usage information was being included in the response even when usage=nothing. Lower bound of StreamCallbacks was bumped to 0.5.1.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (f73e683) to head (a58a567).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   92.03%   92.02%   -0.02%     
==========================================
  Files          49       49              
  Lines        4771     4776       +5     
==========================================
+ Hits         4391     4395       +4     
- Misses        380      381       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svilupp svilupp merged commit b95f6c9 into main Dec 5, 2024
5 of 6 checks passed
@svilupp svilupp deleted the fix-json-type branch December 5, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant