fix connection leak on retrofit OAuth token renewal

swagger-api · Dec 22, 2023 · b30745e · b30745e
1 parent 639b037
commit b30745e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/src/main/resources/handlebars/Java/libraries/retrofit/auth/OAuth.mustache b/src/main/resources/handlebars/Java/libraries/retrofit/auth/OAuth.mustache
@@ -113,8 +113,14 @@ public class OAuth implements Interceptor {
 
             // 401/403 most likely indicates that access token has expired. Unless it happens two times in a row.
             if ( response != null && (response.code() == HTTP_UNAUTHORIZED || response.code() == HTTP_FORBIDDEN) && updateTokenAndRetryOnAuthorizationFailure ) {
-                if (updateAccessToken(requestAccessToken)) {
-                    return retryingIntercept( chain, false );
+                try {
+                    if (updateAccessToken(requestAccessToken)) {
+                        response.body().close();
+                        return retryingIntercept( chain, false );
+                    }
+                } catch (Exception e) {
+                    response.body().close();
+                    throw e;
                 }
             }
             return response;

diff --git a/src/main/resources/handlebars/Java/libraries/retrofit2/auth/OAuth.mustache b/src/main/resources/handlebars/Java/libraries/retrofit2/auth/OAuth.mustache
@@ -113,8 +113,15 @@ public class OAuth implements Interceptor {
 
             // 401/403 most likely indicates that access token has expired. Unless it happens two times in a row.
             if ( response != null && (response.code() == HTTP_UNAUTHORIZED || response.code() == HTTP_FORBIDDEN) && updateTokenAndRetryOnAuthorizationFailure ) {
-                if (updateAccessToken(requestAccessToken)) {
-                    return retryingIntercept( chain, false );
+                if ( response != null && (response.code() == HTTP_UNAUTHORIZED || response.code() == HTTP_FORBIDDEN) && updateTokenAndRetryOnAuthorizationFailure ) {
+                try {
+                    if (updateAccessToken(requestAccessToken)) {
+                        response.body().close();
+                        return retryingIntercept( chain, false );
+                    }
+                } catch (Exception e) {
+                    response.body().close();
+                    throw e;
                 }
             }
             return response;