Spring - fix jakarta imports for validation-mode 'strict' #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configuring generator to use imports from the jakarta-namespace, then no javax-imports should be present in the generated files
DaScheid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR directly addresses commit 2835d9d which was added in #1308 :
When configuring the generator to use imports from the jakarta-namespace, then no javax-imports should be present in the generated files
Current status (before this PR):
Generating Spring-sources with the new default validation-mode 'strict' creates java-files 'NotUndefined.java' and 'NotUndefinedValidator.java' with 'javax'-imports independent of the 'jakarta'-flag. This leads to a compile-time error, as these javax-imports cannot be found.
Updated behavior:
Dependant on the 'jakarta'-setting on the generator either 'javax'- or 'jakarta'-imports are generated