Add operation index to PathException for detailed error reporting
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's add op index via a setter function instead of constructor, so that there is no breaking change of constructor signature. |
Enhanced the `PathException` exception class to include an operation index, identifying the specific operation that caused the exception. Modified the `JsonPatch` class to pass this additional parameter when throwing the `PathException`. Updated the corresponding tests to reflect these changes.
MuhammadJaziraly
force-pushed
the
add-op-index
branch
from
8efb691
to
27f5d03
Compare
|
Done ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this change is to have the index for the operation in cases where two identical operations target the same resource.
For example, if two identical remove operations target the same resource, the latter will fail because the first operation already removed the resource.
By having the index, we can accurately identify and report the failing operation.