Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mingw support [AP-2090] #145

Merged
merged 29 commits into from
Dec 20, 2024
Merged

add mingw support [AP-2090] #145

merged 29 commits into from
Dec 20, 2024

Conversation

sokhealy
Copy link
Contributor

@sokhealy sokhealy commented Dec 4, 2024

Add MingW Cross Compiler Toolchain

Testing: The current consumer of this toolchain is Starling-Core.
This toolchain is limited to an x86_64 Linux host to build an x86_64 Windows target. With this toolchain, we are generating a binary and a static library.

The artifacts were generated using CI/CD and were tested on Linux using Wine and on a Windows 11 system.
The static library that was generated was also tested on Windows 11 to generate the binary and static data was passed, and the results were compared.

The same steps above were also done on an x86_64 Ubuntu 24.04 developer machine.

@sokhealy sokhealy force-pushed the sokhealy/mingw_support branch from 9ba162b to 8624641 Compare December 4, 2024 22:38
@sokhealy sokhealy changed the title add mingw support add mingw support [AP-2090] Dec 13, 2024
@sokhealy sokhealy marked this pull request as ready for review December 18, 2024 16:03
@sokhealy sokhealy requested a review from a team as a code owner December 18, 2024 16:03
Copy link
Contributor

@sbmueller sbmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Difficult to review for me as I'm unfamiliar with Bazel. For me the most valuable information would be how this was tested, could you maybe extend the description by that?

WORKSPACE Outdated Show resolved Hide resolved
cc/toolchains/llvm_x86_64_windows/BUILD.bazel Show resolved Hide resolved
cc/toolchains/llvm_x86_64_windows/BUILD.bazel Show resolved Hide resolved
@sokhealy sokhealy requested a review from a team December 19, 2024 17:37
Copy link
Contributor

@sbmueller sbmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarifications, LGTM

@sbmueller sbmueller requested a review from a team December 19, 2024 17:42
Copy link

@Madhunika-atmakuri Madhunika-atmakuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the parts I could understand, LGTM. We can merge this for now and come back to add additional stuff if needed.

@sokhealy sokhealy merged commit c33a467 into main Dec 20, 2024
1 check passed
@sokhealy sokhealy deleted the sokhealy/mingw_support branch December 20, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants