-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mingw support [AP-2090] #145
Conversation
9ba162b
to
8624641
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Difficult to review for me as I'm unfamiliar with Bazel. For me the most valuable information would be how this was tested, could you maybe extend the description by that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarifications, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the parts I could understand, LGTM. We can merge this for now and come back to add additional stuff if needed.
Add MingW Cross Compiler Toolchain
Testing: The current consumer of this toolchain is Starling-Core.
This toolchain is limited to an x86_64 Linux host to build an x86_64 Windows target. With this toolchain, we are generating a binary and a static library.
The artifacts were generated using CI/CD and were tested on Linux using Wine and on a Windows 11 system.
The static library that was generated was also tested on Windows 11 to generate the binary and static data was passed, and the results were compared.
The same steps above were also done on an x86_64 Ubuntu 24.04 developer machine.