Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative paths, new path mapping setting, better diagnostics #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TibboddiT
Copy link

Motivation

  • phpstan is sometimes executed in a php container, so most paths are more useful if they are relatives
  • no indication of the origin on problems
  • only the first char of the line is underlined when problem occurs

Changes

  • Use relative paths where possible
  • Add pathMappings settings used for resolving files path collected from phpstan output (comma-separated list of src:dest elements, with default: /srv/app:. to handle most docker use cases).
  • Diagnostic range offsets (start at first non-whitechar and stops at last non-whitechar of line)
  • Add source property on diagnostics, to get an indication of problem origin from UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant