Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reports): export multiple S-21 cards #2524

Merged
merged 9 commits into from
Sep 16, 2024
Merged

feat(reports): export multiple S-21 cards #2524

merged 9 commits into from
Sep 16, 2024

Conversation

rhahao
Copy link
Member

@rhahao rhahao commented Sep 16, 2024

No description provided.

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
organized-app ✅ Ready (Inspect) Visit Preview Sep 16, 2024 9:48am

Copy link
Contributor

coderabbitai bot commented Sep 16, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve significant updates to the linting configuration and structure of the codebase, including the removal and addition of ESLint configuration files, modifications to various component files, and enhancements in error handling. The updates also include refinements to type definitions, improvements in event handling, and adjustments to visual components, aiming to streamline the development process and improve code quality.

Changes

File(s) Change Summary
.eslintignore Removed patterns for CSS, SVG, WOFF, and WOFF2 files, allowing ESLint to lint these file types.
.eslintrc.json Deleted ESLint configuration file containing settings for JavaScript, React, and TypeScript linting.
eslint.config.js Added a new ESLint configuration file with comprehensive settings for JavaScript, TypeScript, and React, including custom import resolution and linting rules.
converter/svg/convert.js Modified SVG rendering logic for the IconLoading component to include a rotation animation and improved class name handling.
src/components/accordion/index.tsx Introduced a new sx prop for style customizations and added an onClick event handler to prevent event propagation.
src/components/assignments_checklist/index.tsx Simplified the invocation of the onChange callback using optional chaining.
src/components/badge/index.tsx Changed equality checks from == to === for color and size properties.
src/components/checkbox/index.tsx Added a click event handler to conditionally stop event propagation and corrected a logical comparison for labelDescription.
src/components/checkbox/index.types.ts Added a new optional stopPropagation property to the CheckboxPropsType.
src/components/congregation_selector/useCongregation.tsx Enhanced error logging by adding console.error(err); in the error handling block.
src/components/dropdown/index.tsx Deleted dropdown-related components, including CustomDropdownContainer, CustomDropdownMenu, and CustomDropdownItem.
src/components/icons/IconLoading.tsx Enhanced the loading icon with a CSS animation for continuous rotation, simplifying the SVG structure.
src/features/app_start/vip/congregation_encryption/congregation_access_code/useCongregationAccessCode.tsx Added error logging with console.error(err); in the error handling block.
src/features/app_start/vip/congregation_encryption/congregation_master_key/useCongregationMasterKey.tsx Added error logging with console.error(err); in the error handling block.
src/features/app_start/vip/oauth/button_base/useButtonBase.tsx Added error logging with console.error(error); in the error handling block.
src/features/congregation/upcoming_events/AddEvent.tsx Refactored the handleDone function to use optional chaining for the onDone callback and removed some inline styles from the TextField component.
src/features/reports/publisher_records/export_S21/index.tsx Introduced functionality for exporting publisher records, including state management for the export modal.
src/services/app/persons.ts Refactored functions related to a person's enrollment and baptism status, enhancing flexibility and accuracy in checks.
src/services/firebase/index.ts Added functionality for connecting to a Firebase Authentication emulator based on an environment variable.

Possibly related PRs

  • fix(reports): update logic to count inactive publishers #2471: The changes in this PR involve updates to the logic for counting inactive publishers, which may relate to the overall handling of publisher records, including how they are displayed or filtered in the application.
  • fix(Field service reports): bug preventing page to open #2489: This PR addresses a bug that prevents a page from opening, which may involve components or logic that interact with the publisher records. The changes in the main PR regarding ESLint configurations could indirectly impact the functionality of components that rely on proper linting for error-free execution.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarqubecloud bot commented Sep 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
12 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
14.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@eslint/[email protected] None 0 47.7 kB eslintbot
npm/@eslint/[email protected] filesystem, unsafe Transitive: environment, eval +11 2.51 MB eslintbot
npm/@eslint/[email protected] None 0 14.2 kB eslintbot, openjsfoundation
npm/[email protected] None 0 14.7 kB arnaud-barre
npm/[email protected] None 0 174 kB sindresorhus

🚮 Removed packages: npm/[email protected]

View full report↗︎

@rhahao rhahao merged commit 063ac8c into sws2apps:main Sep 16, 2024
12 checks passed
Copy link

cypress bot commented Sep 16, 2024

organized-app    Run #1281

Run Properties:  status check passed Passed #1281  •  git commit 063ac8c99e: feat(reports): export multiple S-21 cards (#2524)
Project organized-app
Branch Review main
Run status status check passed Passed #1281
Run duration 00m 06s
Commit git commit 063ac8c99e: feat(reports): export multiple S-21 cards (#2524)
Committer Rasamoelina, Haja Onjatiana
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@rhahao
Copy link
Member Author

rhahao commented Nov 30, 2024

🎉 This PR is included in version 2.130.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant