-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): update UI and fix bugs for credit hours and assignment restrictions #3055
Changes from 12 commits
84593fe
9ab1049
b649d82
c67e52d
cca1acd
f395175
a8a47a7
e1e497e
b9294ec
5041b25
5d20c00
1c28eb1
89c911d
a72181e
1fbff39
9714a89
f7f1a13
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,6 +122,7 @@ | |
"tr_pioneers": "Pioneers", | ||
"tr_reminderPublisherReport": "Submit your monthly field service report", | ||
"tr_reminderPublisherReportDesc": "It should be submitted to the secretary no later than the 6th day of the month.", | ||
"tr_reminderBranchReport": "The Congregation Field Service and Meeting Attendance (S-1) report hasn’t been submitted yet", | ||
"tr_reminderBranchReportDesc": "It should be submitted to the branch office no later than the 20th day of the month." | ||
"tr_reminderBranchReport": "The Congregation Field Service and Meeting Attendance (S-1) report is not yet ready", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @FussuChalice: one last change please: could you update your local file in this line? It has been changed but it seems like yours is still the old one and this will overwrite the last update if not changed. Thanks. |
||
"tr_reminderBranchReportDesc": "It should be submitted to the branch office no later than the 20th day of the month.", | ||
"tr_onlyAvailableForPioneers": "Only available for pioneers" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FussuChalice, could you please move the added logic inside the hooks for this component? Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, of course. No problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FussuChalice, I mean to move theme inside
useAssignmentGroup.tsx
file. Thanks.