Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] subcomment expansion; and fixed blocking #114

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

Nathaniel-Wu
Copy link
Collaborator

添加了一个在奖杯TIPS和游戏评论页面展开隐藏的子评论的功能。
游戏评论 测试页面 1奖杯TIPS 测试页面 1:比较新的游戏所有的子评论都是隐藏的。
游戏评论 测试页面 2奖杯TIPS 测试页面 2:稍微老一点的游戏,只有日期比较新的子评论是隐藏的。
更老的游戏根本没有子评论功能,无须测试。
这功能逻辑比我预想的要复杂,有两点原因:P9的载入子评论的代码一次只能点一个,一次点多个也只会载入一个,而且会串,载入出来的子评论可能不在正确的位置;用的IntersectionObserver实现lazy-loading减轻服务器负担,会触发很多重复的事件。

另外修复了下黑名单(其实修了有一段时间了但我当时忘记提PR了)。

@swsoyee swsoyee merged commit 23bcfd0 into swsoyee:master Apr 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants