Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loader in between renders of pages #137

Merged
merged 2 commits into from
Jan 10, 2024
Merged

feat: loader in between renders of pages #137

merged 2 commits into from
Jan 10, 2024

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Jan 8, 2024

Description

This PR add spinner upon navigation

Related Issue Or Context

Closes: #136

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@wainola wainola requested a review from MakMuftic January 8, 2024 00:11
Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6ef3e18
Status: ✅  Deploy successful!
Preview URL: https://ee27367b.explorer-ui-qxq.pages.dev
Branch Preview URL: https://feat-loader.explorer-ui-qxq.pages.dev

View logs

@wainola wainola merged commit 16d3394 into main Jan 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show loading spinner in between page renders
2 participants