Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing fee render logic #147

Merged
merged 3 commits into from
Feb 28, 2024
Merged

fix: fixing fee render logic #147

merged 3 commits into from
Feb 28, 2024

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Feb 6, 2024

Description

Fix fee render using fee data on updated Fee object

Related Issue Or Context

Closes: #146

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

Copy link

cloudflare-workers-and-pages bot commented Feb 6, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0768233
Status: ✅  Deploy successful!
Preview URL: https://56d1fad9.explorer-ui-qxq.pages.dev
Branch Preview URL: https://fix-fee-values.explorer-ui-qxq.pages.dev

View logs

@wainola
Copy link
Contributor Author

wainola commented Feb 6, 2024

update: waiting for this issue to be merged to update this PR.

@wainola wainola marked this pull request as ready for review February 27, 2024 12:53
@wainola wainola requested review from MakMuftic and LyonSsS February 27, 2024 12:54
Copy link
Contributor

@LyonSsS LyonSsS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LyonSsS
Copy link
Contributor

LyonSsS commented Feb 27, 2024

Please update the displayed fee for Contract Call as well
image.png

@LyonSsS
Copy link
Contributor

LyonSsS commented Feb 27, 2024

image
This is now fixed ( addressed)

@LyonSsS
Copy link
Contributor

LyonSsS commented Feb 28, 2024

sygUSDC logic fee logic fixed
image.png
Ignore the multiple decimals show for sygUSDC on EVM as it is set to 6 decimals currently ( same as substrate and the same as mainnet )

Copy link
Contributor

@LyonSsS LyonSsS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pass for QA

@wainola wainola merged commit 723978c into main Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display USDC fees for USDC transfers from Substrate to EVM
3 participants