Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: direct link #161

Merged
merged 4 commits into from
Feb 28, 2024
Merged

feat: direct link #161

merged 4 commits into from
Feb 28, 2024

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Feb 26, 2024 •
edited
Loading

Description

Updates to render direct link

Related Issue Or Context

Closes: #154

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 26, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: da511ca
Status: ✅  Deploy successful!
Preview URL: https://67680537.explorer-ui-qxq.pages.dev
Branch Preview URL: https://feat-direct-link.explorer-ui-qxq.pages.dev

View logs

@wainola wainola marked this pull request as ready for review February 26, 2024 20:44
@wainola wainola requested review from MakMuftic and LyonSsS February 26, 2024 20:45
LyonSsS
LyonSsS approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@LyonSsS LyonSsS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA done - passsed

@wainola wainola merged commit e6fa560 into main Feb 28, 2024
3 checks passed
@MakMuftic MakMuftic mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LyonSsS LyonSsS LyonSsS approved these changes

@MakMuftic MakMuftic Awaiting requested review from MakMuftic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Direct link to details of a transfer from Sygma Scan, is not loaded if it comes from a third party
2 participants
@wainola @LyonSsS