Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding optimism icon #193

Merged
merged 2 commits into from
Sep 30, 2024
Merged

fix: adding optimism icon #193

merged 2 commits into from
Sep 30, 2024

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Sep 25, 2024

Description

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@wainola wainola requested a review from MakMuftic September 25, 2024 13:13
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 25, 2024 •
edited
Loading

Deploying sygma-explorer-test with  Cloudflare Pages  Cloudflare Pages

Latest commit: 09d7686
Status: ✅  Deploy successful!
Preview URL: https://a300e37c.explorer-ui-qxq.pages.dev
Branch Preview URL: https://fix-optimism-logo.explorer-ui-qxq.pages.dev

View logs

@MakMuftic
Copy link
Contributor

LGTM, can we just also add Arbitrum here @wainola

@wainola wainola merged commit 0bcedfb into main Sep 30, 2024
3 checks passed
@MakMuftic MakMuftic mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic MakMuftic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wainola @MakMuftic