Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misc fixes #84

Merged
merged 3 commits into from
Oct 3, 2023
Merged

fix: misc fixes #84

merged 3 commits into from
Oct 3, 2023

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Sep 29, 2023

Description

  • updates on fee render
  • adding new networks icons
  • other improvements

Related Issue Or Context

Closes: #83

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@wainola wainola requested a review from FSM1 September 29, 2023 23:18
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 29, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb00272
Status: ✅  Deploy successful!
Preview URL: https://ea777fbc.explorer-ui-qxq.pages.dev
Branch Preview URL: https://fix-misc-fixes.explorer-ui-qxq.pages.dev

View logs

@wainola wainola requested a review from MakMuftic September 29, 2023 23:20
@MakMuftic
Copy link
Contributor

@wainola can we just change how we name GMP messages to something simpler like: Generic
image

@MakMuftic MakMuftic merged commit 07e7369 into main Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misc fixes: format fee amount for substrate transfer
2 participants