Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactor deposit handlers #10

Closed
wants to merge 7 commits into from
Closed

chore: Refactor deposit handlers #10

wants to merge 7 commits into from

Conversation

tcar121293
Copy link

refactor deposit handlers

Description

refactor deposit handlers so we are able to pass arbitrary function and arbitrary config to each deposit handler

Related Issue Or Context

Closes: #4

How Has This Been Tested? Testing details.

unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Go Test coverage is 66.1 %\ ✨ ✨ ✨

@tcar121293
update mock;
b644819 
Signed-off-by: tcar <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Go Test coverage is 66.1 %\ ✨ ✨ ✨

mpetrun5
mpetrun5 requested changes Oct 5, 2023
View reviewed changes
chains/evm/deposithandlers/deposit-handler.go Outdated Show resolved Hide resolved
chains/evm/deposithandlers/deposit-handler.go Outdated Show resolved Hide resolved
chains/evm/deposithandlers/deposit-handler.go Outdated Show resolved Hide resolved
chains/evm/deposithandlers/erc20.go Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Go Test coverage is 65.6 %\ ✨ ✨ ✨

@tcar121293 tcar121293 requested a review from mpetrun5 October 9, 2023 08:00
@mpetrun5 mpetrun5 added the DNM label Oct 11, 2023
@mpetrun5
Copy link

This looks good for now, but will be used when we integrate core into relayers as core doesn't have deposit handers anymore

@mpetrun5 mpetrun5 closed this Apr 4, 2024
@mpetrun5 mpetrun5 deleted the tcar/refactor-depositHandler branch April 4, 2024 12:40
@mpetrun5 mpetrun5 restored the tcar/refactor-depositHandler branch April 4, 2024 12:40
@mpetrun5 mpetrun5 deleted the tcar/refactor-depositHandler branch October 28, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmlinaric nmlinaric nmlinaric approved these changes

@P1sar P1sar Awaiting requested review from P1sar

@MakMuftic MakMuftic Awaiting requested review from MakMuftic MakMuftic is a code owner

@mpetrun5 mpetrun5 Awaiting requested review from mpetrun5 mpetrun5 is a code owner

Assignees
No one assigned
Labels
DNM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor deposit handlers
3 participants
@tcar121293 @mpetrun5 @nmlinaric