forked from ChainSafe/chainbridge-core
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable messages both ways #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrun5
requested review from
P1sar,
tcar121293,
MakMuftic and
nmlinaric
as code owners
October 5, 2023 14:17
Go Test coverage is 64.7 %\ ✨ ✨ ✨ |
Go Test coverage is 64.7 %\ ✨ ✨ ✨ |
tcar121293
requested changes
Oct 10, 2023
tcar121293
approved these changes
Oct 16, 2023
MakMuftic
approved these changes
Oct 18, 2023
Go Test coverage is 64.7 %\ ✨ ✨ ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
Proposal
and M̀essage` be generic types and enable messages to be sent both wayswithout committing to what that message is.
Description
Related Issue Or Context
Closes: #2
Closes: #1
How Has This Been Tested? Testing details.
Types of changes
Checklist: