Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable messages both ways #11

Merged
merged 38 commits into from
Oct 18, 2023
Merged

Conversation

mpetrun5
Copy link

@mpetrun5 mpetrun5 commented Oct 5, 2023

Make Proposal and M̀essage` be generic types and enable messages to be sent both ways
without committing to what that message is.

Description

Related Issue Or Context

Closes: #2
Closes: #1

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Go Test coverage is 64.7 %\ ✨ ✨ ✨

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Go Test coverage is 64.7 %\ ✨ ✨ ✨

relayer/relayer.go Show resolved Hide resolved
@mpetrun5 mpetrun5 requested a review from tcar121293 October 16, 2023 14:19
relayer/relayer.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Go Test coverage is 64.7 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit 0f397e3 into main Oct 18, 2023
7 checks passed
@mpetrun5 mpetrun5 deleted the mpetrun5/enable-messages-both-ways branch October 23, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable message sending both ways Return Proposal from message handler
3 participants