Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix overflow and unexpected behavior of deposit nonce set/get #127

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

tolak
Copy link
Collaborator

@tolak tolak commented Sep 9, 2023

  • Fix the overflow issue
  • Fix deposit nonce set/get so that it can be set to the correct page

@tolak tolak requested review from freddyli7 and MakMuftic September 9, 2023 17:30
@tolak tolak force-pushed the fix-nonce-overflow branch from 95abf48 to 0046451 Compare September 9, 2023 17:42
Copy link
Contributor

@freddyli7 freddyli7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tolak tolak merged commit 814307b into main Sep 11, 2023
6 checks passed
@tolak tolak deleted the fix-nonce-overflow branch September 11, 2023 05:49
@MakMuftic MakMuftic mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants