feat: display transfer gas cost estimation #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saadahmsiddiqui
requested review from
Lykhoyda,
wainola and
mpetrunic
as code owners
mpetrunic
force-pushed
the
feat/display_gas_fee_estimation
branch
from
2b46deb to
0302a6c
Compare
mpetrunic
previously approved these changes
Apr 16, 2024
packages/widget/src/components/transfer/fungible/transfer-detail/transfer-detail.ts
Outdated
Show resolved
Hide resolved
wainola
suggested changes
Apr 16, 2024
packages/widget/src/components/transfer/fungible/transfer-detail/styles.ts
Outdated
Show resolved
Hide resolved
packages/widget/src/components/transfer/fungible/transfer-detail/transfer-detail.ts
Show resolved
Hide resolved
packages/widget/src/components/transfer/fungible/transfer-detail/transfer-detail.ts
Outdated
Show resolved
Hide resolved
…tocol/sygma-widget into feat/display_gas_fee_estimation
mpetrunic
changed the title
mpetrunic
reviewed
Apr 18, 2024
There was a problem hiding this comment.
A lot of logic in this file without tests :S
There was a problem hiding this comment.
Will be resolved in separe PR. Related issue #177
…/display_gas_fee_estimation
mpetrunic
previously approved these changes
Apr 19, 2024
wainola
previously approved these changes
Apr 19, 2024
Fixed |
wainola
approved these changes
Apr 19, 2024
mpetrunic
approved these changes
Apr 22, 2024
mpetrunic
pushed a commit
that referenced
this pull request
May 7, 2024
## Description Display gas estimation of transactions that will be executed ## Related Issue Or Context Closes: #157 ## How Has This Been Tested? Testing details. - [x] Mocked gas fee test ## Types of changes - [x] Transactions gas fee estimations for evm and substrate networks ## Checklist: - [x] Add tests.
Merged
MakMuftic
added a commit
that referenced
this pull request
Jun 13, 2024
🤖 I have created a release *beep* *boop*
---
<details><summary>@buildwithsygma/sygmaprotocol-react-widget:
0.1.3</summary>
### Dependencies
* The following workspace dependencies were updated
* dependencies
* @buildwithsygma/sygmaprotocol-widget bumped to 0.2.0
</details>
<details><summary>sygmaprotocol-widget: 0.2.0</summary>
##
[0.2.0](sygmaprotocol-widget-v0.1.2...sygmaprotocol-widget-v0.2.0)
(2024-06-13)
### Features
* automatically add unknown source evm network into wallet
([#162](#162))
([d5886bd](d5886bd))
* display amount to be received on destination
([#168](#168))
([347f7a5](347f7a5))
* Display Fee
([#145](#145))
([872703d](872703d))
* display transfer gas cost estimation
([#174](#174))
([b154555](b154555))
* enable developers to configure network whitelisting
([#170](#170))
([5db505f](5db505f))
* enable user to specify wallets
([#161](#161))
([8a02170](8a02170))
* Retry loading bridge routes
([#136](#136))
([8e0101f](8e0101f))
* substrate fungible transfer
([#134](#134))
([337f1b7](337f1b7))
* wallet account selector for substrate
([#106](#106))
([79127fd](79127fd)),
closes [#74](#74)
### Bug Fixes
* amount to receive
([#196](#196))
([8c2cdad](8c2cdad))
* destination address format
([#197](#197))
([250ea35](250ea35))
* explorer urls when adding networks
([#200](#200))
([d65d99a](d65d99a))
* Fixed amount to receive decimals
([#208](#208))
([be23500](be23500))
* Gas Fee estimation behavior, is not consistent for the actual transfer
TX ([#204](#204))
([d57233e](d57233e))
* handling transfer cancellation on substrate
([#195](#195))
([6ce25cb](6ce25cb))
* resource name
([#201](#201))
([1215dcc](1215dcc))
* resource selector
([#199](#199))
([81bae38](81bae38))
* small fix for tangle connection
([#212](#212))
([557d71e](557d71e))
* source switch reset
([#206](#206))
([1b1f92c](1b1f92c)),
closes [#205](#205)
* typesafety when handling changed properties
([#141](#141))
([692e269](692e269))
</details>
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display gas estimation of transactions that will be executed
Related Issue Or Context
Closes: #157
How Has This Been Tested? Testing details.
Types of changes
Checklist: