Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SDK Manager package #25
feat: SDK Manager package #25
Changes from 71 commits
f31162f
c2bb537
fc8d5b7
c729e41
c2731ea
4e0bda8
2f1582e
62664bf
6e05bbe
015810a
5508cf2
67b3ea9
7a94ca8
113a79d
3d9c8b4
7fba17b
3de7750
097207b
eb064d9
ba3d6f8
6cde381
addc335
5bf4608
ca68f93
529e286
4dfacf0
204ed59
4835d11
0f4ec9c
58e86e0
d178cbe
a65aed8
ee29c5b
865d20e
5b14fde
9ff4b4e
a714f80
be88088
8e80578
ebd59ef
127c05e
6731275
b358fb0
85c7703
3df49d9
6d35ac6
429788e
240227e
3fb0880
4c6ff2a
9ca3ed9
33c3954
f216135
ad3dfe7
fd61e24
2632e23
55e0ad7
7de0923
74f19a9
7f9b999
9866a36
11f5765
de53598
2341b11
a3fda17
21a641b
e2c4a4f
ea0e314
e098feb
d873999
33f3d9d
0036759
0b06ee2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: negative logic adds a bit more cognitive load, so maybe it'd be a good idea to remove
!
in the condition and switch clauses 🤷There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it'd be good to have consistent naming with context (providers)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @wainola
when refactoring, it'd be good that both managers follow same naming convention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently this is repeated only twice, but if more methods will need to do these checks, it'd be good to extract them in a method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this
async
here?