Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cf deployment #59

Merged
merged 10 commits into from
Jan 22, 2024
Merged

chore: add cf deployment #59

merged 10 commits into from
Jan 22, 2024

Conversation

Lykhoyda
Copy link
Contributor

@Lykhoyda Lykhoyda commented Jan 18, 2024

Description

  • Add widget package deployment during the push to the main and when opening a new PR
  • Separate deployment of the widget package when a new version is released
  • Add deployment for react-widget on push and opening a PR
  • Add production deployment for react-widget on a new release

Closes: #28

@Lykhoyda Lykhoyda marked this pull request as ready for review January 18, 2024 17:02
@Lykhoyda Lykhoyda requested a review from wainola January 18, 2024 17:06
@wainola
Copy link
Contributor

wainola commented Jan 19, 2024

@Lykhoyda how do we envision to deploy the react package? I have this question after reading the deploy files for the react package

Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need prod deployment (we are building library here), we just need deploy previews.
It's probably best to rebase against #58

Copy link

cloudflare-workers-and-pages bot commented Jan 19, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 170c2fc
Status: ✅  Deploy successful!
Preview URL: https://f2cdf93a.sygma-widget.pages.dev
Branch Preview URL: https://lykhoyda-cf-deployment.sygma-widget.pages.dev

View logs

@@ -7,7 +7,7 @@
"license": "LGPL-3.0-or-later",
"type": "module",
"dependencies": {
"@lit-labs/react": "2.0.3"
"@lit-labs/react": "2.1.2"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes done to trigger the react workflow

@Lykhoyda
Copy link
Contributor Author

@Lykhoyda how do we envision to deploy the react package? I have this question after reading the deploy files for the react package

@wainola the deployment will serve the static file like index.html. The react project is empty for now, so it's just a preparation of the code for future code deployments.

@wainola wainola self-requested a review January 19, 2024 16:10
@mpetrunic mpetrunic changed the title feat: add cf deployment chore: add cf deployment Jan 22, 2024
@mpetrunic mpetrunic merged commit b85ab29 into main Jan 22, 2024
5 checks passed
@mpetrunic mpetrunic deleted the lykhoyda/cf_deployment branch January 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow to deploy to cloudflare pages
3 participants