-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add cf deployment #59
Conversation
@Lykhoyda how do we envision to deploy the react package? I have this question after reading the deploy files for the react package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need prod deployment (we are building library here), we just need deploy previews.
It's probably best to rebase against #58
Deploying with Cloudflare Pages
|
be37334
to
4ba4750
Compare
@@ -7,7 +7,7 @@ | |||
"license": "LGPL-3.0-or-later", | |||
"type": "module", | |||
"dependencies": { | |||
"@lit-labs/react": "2.0.3" | |||
"@lit-labs/react": "2.1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes done to trigger the react workflow
@wainola the deployment will serve the static file like index.html. The react project is empty for now, so it's just a preparation of the code for future code deployments. |
4ba4750
to
a6d67eb
Compare
Description
Closes: #28