feat: base interface implementation for react package #61

wainola · 2024-01-22T03:03:58Z

Description

Related Issue Or Context

Closes: #10

How Has This Been Tested? Testing details.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation

Checklist:

I have commented my code, particularly in hard-to-understand areas.
I have ensured that all acceptance criteria (or expected behavior) from issue are met
I have updated the documentation locally and in sygma-docs.
I have added tests to cover my changes.
I have ensured that all the checks are passing and green, I've signed the CLA bot

mpetrunic · 2024-01-22T08:58:39Z

packages/widget/src/widget.ts

+  @property({
+    type: Object
+  })
+  network?: Network;


I'm not sure what is the usecase for this?

Wouldn't it not make more sense to allow them to pass "whitelistedSourceChains" & "whitelistedDestinationChains"? Maybe we can use https://chainagnostic.org/CAIPs/caip-2? cc @MakMuftic

So they can configure the widget to send only from "Etheruem mainnet" to ["Optimism", "Polygon"].
If they don't submit anything we assume the widget can transfer to any network.

I agree here, having a whitelist for source and destination chains is a functionality we want to support 👍

In regards to the CAIP suggestion @mpetrunic, supporting this makes a lot of sense (I would love it if this was on our radar before).
My concern here is if this makes more sense on the SDK level, as we will always need to remap it back to Sygmas resourceIDs and domainIDs.

It should be possible to map caip to sygma resource id in SDK, no?
I'm thinking if we wanna do that change now, else we will have to cut major version for widget soon.

packages/widget/src/widget.ts

Co-authored-by: Marin Petrunić <[email protected]>

cloudflare-workers-and-pages · 2024-01-24T02:39:27Z

Deploying with Cloudflare Pages

Latest commit:	`492eae4`
Status:	✅ Deploy successful!
Preview URL:	https://9c50080d.sygma-widget.pages.dev
Branch Preview URL:	https://feat-react-package.sygma-widget.pages.dev

View logs

packages/widget/src/interfaces/index.ts

packages/widget/src/widget.ts

packages/widget/src/interfaces/index.ts

Co-authored-by: Marin Petrunić <[email protected]>

examples/react-widget-app/package.json

sztok7

🚀

BeroBurny · 2024-02-08T14:10:03Z

examples/react-widget-app/package.json

+    "build": "tsc && vite build",
+    "lint": "yarn run lint:types && yarn run lint:code",
+    "lint:types": "tsc -p ./tsconfig.json --noEmit",
+    "lint:code": "eslint '{src,tests}/**/*.ts'",


It is intentional to just check ts files?

🤖 I have created a release *beep* *boop* --- <details><summary>sygmaprotocol-react-widget: 0.1.0</summary> ## 0.1.0 (2024-04-19) ### Features * base interface implementation for react package ([#61](#61)) ([0f38d7c](0f38d7c)) * EmvWallet class base implementation ([74c9649](74c9649)) ### Bug Fixes * fix sygma namespace ([f9ab963](f9ab963)) ### Miscellaneous Chores * **main:** release 0.0.1 ([8cff038](8cff038)) * release 0.1.0 ([#101](#101)) ([c8f1aed](c8f1aed)) ### Dependencies * The following workspace dependencies were updated * dependencies * @buildwithsygma/sygmaprotocol-widget bumped to 0.1.0 </details> <details><summary>sygmaprotocol-widget: 0.1.0</summary> ## [0.1.0](sygmaprotocol-widget-v0.1.0...sygmaprotocol-widget-v0.1.0) (2024-04-19) ### Features * action buttons v2 ([#91](#91)) ([5b2fbc5](5b2fbc5)) * add account balance refreshing for erc20 and evm native token ([#88](#88)) ([e135edc](e135edc)) * adding token balance to amount component ([c7b6268](c7b6268)) * address to transfer ([#56](#56)) ([9fa87ad](9fa87ad)) * allow bridge environment configuration ([#104](#104)) ([7dd44e4](7dd44e4)) * amount input styles update ([#77](#77)) ([6101005](6101005)) * base implementation of network selector for the widget component ([b04ac49](b04ac49)) * base interface implementation for react package ([#61](#61)) ([0f38d7c](0f38d7c)) * base layout for widget + styles ([e259dca](e259dca)) * changes to properties names ([291e753](291e753)) * creation of mixin for property declaration and using component to render view ([d22772e](d22772e)) * EmvWallet class base implementation ([74c9649](74c9649)) * evm and substrate wallet connection ([#72](#72)) ([ccf2049](ccf2049)) * evm token transfer logic ([#95](#95)) ([7ae8547](7ae8547)) * externalize wallet connect connection through props ([#94](#94)) ([cc8617d](cc8617d)) * improvements on selector implementation and misc changes ([940317f](940317f)) * network selector component ([#70](#70)) ([003416e](003416e)) * overlay ([#79](#79)) ([751ddb1](751ddb1)) * remove wrong entrypoint for the widget ([9e0007e](9e0007e)) * removing abi definition, calling sdk function to get balance and updating package.json file ([95b0653](95b0653)) * renaming files, improvements over style and adding the components into the main layout ([edd4e35](edd4e35)) * reset fields after transfer is complete ([#163](#163)) ([762e95a](762e95a)), closes [#133](#133) * SDK Manager package ([#25](#25)) ([f9a8793](f9a8793)) * set destination address for EVM ([#129](#129)) ([679346a](679346a)) * small modifications to amount component and connect component ([1fda019](1fda019)) * transfer status ([#89](#89)) ([76c0265](76c0265)) * upon clicking on max, render max value and trigger change event ([24746f5](24746f5)) * utils functions, styles on diff file and rendering icons per chain id ([a2bc154](a2bc154)) ### Bug Fixes * add css reset ([#75](#75)) ([d512f58](d512f58)) * address input not submitted on paste ([#108](#108)) ([9acf7f0](9acf7f0)) * amount selector prefilled with zero ([#109](#109)) ([b178429](b178429)) * bug where user could proceed with invalid destination address ([#176](#176)) ([634a121](634a121)), closes [#164](#164) * clear wallet context on disconnect ([#152](#152)) ([4a497e2](4a497e2)) * easier amount input ([#159](#159)) ([8d6620e](8d6620e)) * error where start new transfer isn't working ([#126](#126)) ([ca4ece0](ca4ece0)) * evm amount is now calculated as user input minus the fee ([#143](#143)) ([d29771e](d29771e)) * fix sygma namespace ([f9ab963](f9ab963)) * incorrect transfer state when disconnecting wallet after transfer completed ([#130](#130)) ([359e6df](359e6df)) * input type and conditional render for token icon ([25d7db3](25d7db3)) * linter issue with style module ([edc34bb](edc34bb)) * max button rounds value ([#137](#137)) ([01901e6](01901e6)) * misc fixes with icons ([#85](#85)) ([fedbcd9](fedbcd9)) * prevent new lines and spaces in address input ([#81](#81)) ([44a318e](44a318e)) * re-validate on account balance change ([#107](#107)) ([7935f81](7935f81)) * removing log ([71f42d6](71f42d6)) * specific dispatchers either for network or token selector ([1ba9de3](1ba9de3)) * substrate address not validated bug ([#128](#128)) ([74191b1](74191b1)) * switch networks and misc fixes ([#127](#127)) ([db9ad8a](db9ad8a)) * Switching to a different TOKEN mapping for "From - TO" relationship is not updated in UI if amount is inserted ([#160](#160)) ([e2d16fd](e2d16fd)) * update sygma sdk version ([#82](#82)) ([6d8447a](6d8447a)) * widget cloudflare deploy ([#68](#68)) ([fe6c36f](fe6c36f)) ### Miscellaneous Chores * **main:** release 0.0.1 ([8cff038](8cff038)) * release 0.1.0 ([#101](#101)) ([c8f1aed](c8f1aed)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

feat: base interface implementation for react package

629e994

mpetrunic reviewed Jan 22, 2024

View reviewed changes

Update packages/widget/src/widget.ts

8037690

Co-authored-by: Marin Petrunić <[email protected]>

wainola added 3 commits January 23, 2024 23:50

chore: pr review and small update to interface

492eae4

feat: updated interfaces for react package

83baf6a

chore: merge with main

196c82d

github-actions bot deployed to sygma-widget (Production) January 25, 2024 12:59 View deployment

chore: remove unused interface

886150d

wainola requested review from mpetrunic and MakMuftic January 25, 2024 13:04

wainola marked this pull request as ready for review January 25, 2024 13:04

github-actions bot deployed to sygma-widget (Production) January 25, 2024 13:04 View deployment

wainola requested a review from sztok7 January 25, 2024 13:08

mpetrunic reviewed Jan 29, 2024

View reviewed changes

wainola and others added 4 commits January 29, 2024 11:01

Update packages/widget/src/interfaces/index.ts

e4318a1

Co-authored-by: Marin Petrunić <[email protected]>

Update packages/widget/src/interfaces/index.ts

f2f4683

Co-authored-by: Marin Petrunić <[email protected]>

Update packages/widget/src/interfaces/index.ts

1de889a

Co-authored-by: Marin Petrunić <[email protected]>

Update packages/widget/src/interfaces/index.ts

6ee30d9

Co-authored-by: Marin Petrunić <[email protected]>

github-actions bot deployed to sygma-widget (Production) January 29, 2024 14:02 View deployment

Update packages/widget/src/interfaces/index.ts

0604620

Co-authored-by: Marin Petrunić <[email protected]>

github-actions bot deployed to sygma-widget (Production) January 29, 2024 14:02 View deployment

wainola and others added 2 commits January 29, 2024 11:03

Update packages/widget/src/interfaces/index.ts

84bcd35

Co-authored-by: Marin Petrunić <[email protected]>

Update packages/widget/src/interfaces/index.ts

12fe767

Co-authored-by: Marin Petrunić <[email protected]>

github-actions bot deployed to sygma-widget (Production) January 29, 2024 14:03 View deployment

wainola and others added 3 commits January 29, 2024 11:03

Update packages/widget/src/interfaces/index.ts

4a58c48

Co-authored-by: Marin Petrunić <[email protected]>

Update packages/widget/src/interfaces/index.ts

18cbeb6

Co-authored-by: Marin Petrunić <[email protected]>

Update packages/widget/src/interfaces/index.ts

df437ab

Co-authored-by: Marin Petrunić <[email protected]>

github-actions bot deployed to sygma-widget (Production) January 29, 2024 14:03 View deployment

github-actions bot deployed to sygma-widget (Production) February 8, 2024 12:34 View deployment

github-actions bot deployed to sygma-react-widget (Production) February 8, 2024 12:34 View deployment

wainola requested a review from mpetrunic February 8, 2024 12:49

chore: fixing some linter issues

b83b25f

wainola requested a review from sztok7 February 8, 2024 13:20

github-actions bot deployed to sygma-widget (Production) February 8, 2024 13:20 View deployment

mpetrunic reviewed Feb 8, 2024

View reviewed changes

examples/react-widget-app/package.json Outdated Show resolved Hide resolved

examples/react-widget-app/package.json Outdated Show resolved Hide resolved

github-actions bot deployed to sygma-react-widget (Production) February 8, 2024 13:21 View deployment

chore: restoring some scripts

9c1285d

github-actions bot deployed to sygma-widget (Production) February 8, 2024 13:25 View deployment

github-actions bot deployed to sygma-react-widget (Production) February 8, 2024 13:25 View deployment

chore: going back to namespace on module

7243c5b

github-actions bot deployed to sygma-widget (Production) February 8, 2024 13:33 View deployment

github-actions bot deployed to sygma-react-widget (Production) February 8, 2024 13:33 View deployment

chore: linter issues

0f62df3

github-actions bot deployed to sygma-widget (Production) February 8, 2024 13:39 View deployment

github-actions bot deployed to sygma-react-widget (Production) February 8, 2024 13:39 View deployment

chore: removing unnecesary dependencies

b5b430c

github-actions bot deployed to sygma-widget (Production) February 8, 2024 13:49 View deployment

github-actions bot deployed to sygma-react-widget (Production) February 8, 2024 13:49 View deployment

wainola requested a review from mpetrunic February 8, 2024 13:52

mpetrunic approved these changes Feb 8, 2024

View reviewed changes

sztok7 approved these changes Feb 8, 2024

View reviewed changes

mpetrunic merged commit 0f38d7c into main Feb 8, 2024
4 checks passed

mpetrunic deleted the feat/react-package branch February 8, 2024 14:09

BeroBurny reviewed Feb 8, 2024

View reviewed changes

MakMuftic mentioned this pull request Feb 7, 2024

chore: release main #60

Merged

BeroBurny mentioned this pull request Feb 8, 2024

React example incorrect lint script #84

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: base interface implementation for react package #61

feat: base interface implementation for react package #61

wainola commented Jan 22, 2024 •

edited

Loading

mpetrunic Jan 22, 2024

MakMuftic Jan 22, 2024

MakMuftic Jan 22, 2024

mpetrunic Jan 23, 2024

cloudflare-workers-and-pages bot commented Jan 24, 2024 •

edited

Loading

sztok7 left a comment

BeroBurny Feb 8, 2024

feat: base interface implementation for react package #61

feat: base interface implementation for react package #61

Conversation

wainola commented Jan 22, 2024 • edited Loading

Description

Related Issue Or Context

How Has This Been Tested? Testing details.

Types of changes

Checklist:

mpetrunic Jan 22, 2024

Choose a reason for hiding this comment

MakMuftic Jan 22, 2024

Choose a reason for hiding this comment

MakMuftic Jan 22, 2024

Choose a reason for hiding this comment

mpetrunic Jan 23, 2024

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Jan 24, 2024 • edited Loading

Deploying with Cloudflare Pages

sztok7 left a comment

Choose a reason for hiding this comment

BeroBurny Feb 8, 2024

Choose a reason for hiding this comment

wainola commented Jan 22, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 24, 2024 •

edited

Loading