Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove extra code, add vite build, add tests #62

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Conversation

mpetrunic
Copy link
Member

@mpetrunic mpetrunic commented Jan 22, 2024

Description

Quite massive change but in it's core it's simplification of everything.
Changes:

  • created single controller WidgetController which reacts to widget changes (it might get crowded at which point we can split into smaller controllers if it makes sense)
    • removed all the context and mixins as it's a widget without navigation and we don't really need context here
  • removed walletcontroller. Mostly because it didn't follow logic where you first select network and than wallet connection depends on selected network.
  • logic code is separated from components
  • added test sample
  • added library building (including types)

We can still reuse old code (by checking out old commit) but it's easier if we start from this simplified setup

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

This was referenced Jan 22, 2024
Copy link

cloudflare-workers-and-pages bot commented Jan 22, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c510bc8
Status: ✅  Deploy successful!
Preview URL: https://e614dc0f.sygma-widget.pages.dev
Branch Preview URL: https://reorg-cleanum.sygma-widget.pages.dev

View logs

sztok7
sztok7 previously approved these changes Jan 22, 2024
@wainola wainola requested a review from sztok7 January 22, 2024 23:32
@mpetrunic mpetrunic merged commit 475bc9c into main Jan 23, 2024
4 checks passed
@mpetrunic mpetrunic deleted the reorg&cleanum branch January 23, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants