Removed static node #943
Merged
Removed static node #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegMakarenko
requested review from
OlegMakarenko and
bassemmagdy
and removed request for
bassemmagdy
src/infrastructure/NodeService.js
Outdated
| let nodePeers = await this.getNodePeers(); | ||
|
|
||
| // Get the chain height and finalized height from HeightStats | ||
| const suggestedChainHeight = nodeHeightStats[0].data.sort((a, b) => b.y - a.y)[0].x; |
There was a problem hiding this comment.
I think statistics service (REST) should return this. It can be also used in other apps
There was a problem hiding this comment.
Yeah, we can add a new endpoint for that.
|
What if statistics service is down? Should we keep a node list in the config for that case? |
In the discord discussion, we should not have any hardcoded node lists. |
AnthonyLaw
force-pushed
the
removed-static-node
branch
from
f6408c4 to
8e2a639
Compare
AnthonyLaw
force-pushed
the
removed-static-node
branch
from
b007de4 to
8d444fa
Compare
src/store/api.js
Outdated
| /** | ||
| * get Nodes list for node selector | ||
| */ | ||
| async nodeSelector({ commit, getters }) { |
There was a problem hiding this comment.
Maybe 'loadNodeList`?
OlegMakarenko
approved these changes
Oct 29, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
AnthonyLaw
added a commit
that referenced
this pull request
Oct 31, 2021
* Update ru.json * Update ru.json * Update src/config/i18n/ru.json Co-authored-by: OlegMakarenko <[email protected]> * Update src/config/i18n/ru.json Co-authored-by: OlegMakarenko <[email protected]> * Update ru.json * fix: display reward program on csv column. * fix: mosaic preview popover * fix: add server response Cache-Control header * fix: Added missing network types * Update ru.json Added changes to the Russian version * Update ru.json * Update ru.json Updated Symbol Explorer (ru) * Update ru.json Updated Symbol Explorer (ru) * Add files via upload * Delete ru.json * Bump path-parse from 1.0.6 to 1.0.7 (#926) Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump url-parse from 1.5.1 to 1.5.2 (#938) Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.2. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.1...1.5.2) --- updated-dependencies: - dependency-name: url-parse dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: add app version on footer. (#931) * Minor fix (#940) * fix: only display relative supply on mosaic detail * fix: missing translation label. * fix: upgraded symbol-sdk to alpha that accepts new rest address format (#944) * fix: enable ru language (#949) * Remove node reward related (#947) * refactor: remove node reward related item * refactor: remove node reward widgets Co-authored-by: OlegMakarenko <[email protected]> * fix: update translation (#950) * fix: update translation * Update src/config/i18n/ua.json Co-authored-by: OlegMakarenko <[email protected]> * Enable https (#932) fix: change ws to wss fix: add logic check isHttpsEnabled for the domain * feat: update latest SDK (#953) * feat: update latest SDK * fix: package dependecy issue * fix: use npm v7 * fix: specify engines version * fix: update footer config (#952) * fix: use address resolution get expire namespace (#930) Co-authored-by: OlegMakarenko <[email protected]> * Removed static node (#943) * feat: add new getAPINodeList method. * fix: removed statis node list * style: fix lint * refactor: request node list used preferred filter * fix: pick the node random base on the list * fix: added limit to node list * fix: rename * Minor update (#954) * refactor: remove unused method * fix: get ssl ready node from service * fix: update default config * style: fix lint and sonar feedback * docs: release note 1.1.1 (#955) * docs: release note 1.1.1 * docs: fix typo Co-authored-by: Klim Geran <[email protected]> Co-authored-by: OlegMakarenko <[email protected]> Co-authored-by: AnthonyLaw <[email protected]> Co-authored-by: Oleg Makarenko <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node