-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tools/shoestring] fix: allow the user to retain their node key #1186
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1186 +/- ##
==========================================
- Coverage 98.25% 98.23% -0.02%
==========================================
Files 162 158 -4
Lines 6630 6515 -115
Branches 143 143
==========================================
- Hits 6514 6400 -114
+ Misses 116 115 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All look good 👍🏼
Added some comment
9cb0eb5
to
cacfd3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
'-outform', 'PEM', | ||
'-algorithm', 'ed25519' | ||
]) | ||
|
||
def _create_ca_private_key(self, directory): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this should be staticmethod too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
problem: migrating from symbol-bootstrap creates a new node key solution: allow the node to retain its node key during bootstrap import and cert renewal.
4d1d270
to
3ffb0eb
Compare
problem: migrating from symbol-bootstrap creates a new node key.
this causes the node to lose their delegated harvesters.
solution: allow the node to retain its node key during bootstrap import and cert renewal.