Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explorer/nodewatch] fix: update the catapult compatible matrix #1204

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

Wayonb
Copy link
Contributor

@Wayonb Wayonb commented Dec 3, 2024

problem: nodewatch does not show the latest version as green.
plus incompatible catapult are not marked as red.
solution: update nodewatch to show the correct colors

@Wayonb Wayonb requested a review from Jaguar0625 December 3, 2024 04:02
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (f3f3e37) to head (0fbf9d6).
Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1204      +/-   ##
==========================================
- Coverage   98.25%   98.22%   -0.03%     
==========================================
  Files         162      157       -5     
  Lines        6630     6496     -134     
  Branches      143      143              
==========================================
- Hits         6514     6381     -133     
+ Misses        116      115       -1     
Flag Coverage Δ
explorer-nodewatch 98.40% <100.00%> (ø)
explorer-rest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
explorer/nodewatch/nodewatch/RoutesFacade.py 96.19% <100.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

@Jaguar0625 Jaguar0625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

problem: nodewatch does not show the latest version as green.
         plus incompatible catapult are not marked as red.
solution: update nodewatch to show the correct colors
@Wayonb Wayonb force-pushed the fix/mark_invalid_catapult_version_red branch from 0fbf9d6 to e59797d Compare December 3, 2024 21:47
@Wayonb Wayonb merged commit 4afb34a into dev Dec 3, 2024
5 checks passed
@Wayonb Wayonb deleted the fix/mark_invalid_catapult_version_red branch December 3, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants