Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explorer/rest]: added mosaic endpoint #709

Draft
wants to merge 10 commits into
base: explorer/rest-namespaces-endpoint
Choose a base branch
from

Conversation

AnthonyLaw
Copy link
Member

@AnthonyLaw AnthonyLaw commented Nov 14, 2023

What was the issue?

  • Implement moasic endpoint.

What's the fix?

  • Added search mosaic by name.
  • Added _format_address_bytes helper function, converting bytes from db to address string.
  • refactor in unit test to fix lint duplicated code issue.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #709 (5599779) into explorer/rest-namespaces-endpoint (38cea45) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                          @@
##           explorer/rest-namespaces-endpoint     #709      +/-   ##
=====================================================================
+ Coverage                              98.24%   98.26%   +0.01%     
=====================================================================
  Files                                    162      163       +1     
  Lines                                   6615     6668      +53     
  Branches                                 143      143              
=====================================================================
+ Hits                                    6499     6552      +53     
  Misses                                   116      116              
Flag Coverage Δ
explorer-nodewatch 98.40% <ø> (ø)
explorer-rest 99.60% <100.00%> (+0.10%) ⬆️
faucet-authenticator 100.00% <ø> (ø)
faucet-backend 98.91% <ø> (ø)
faucet-frontend 100.00% <ø> (ø)
lightapi-python 98.35% <ø> (ø)
tools-shoestring 96.76% <ø> (ø)
tools-vanity 99.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
explorer/rest/rest/__init__.py 98.78% <100.00%> (+0.09%) ⬆️
explorer/rest/rest/db/NemDatabase.py 100.00% <100.00%> (ø)
explorer/rest/rest/facade/NemRestFacade.py 100.00% <100.00%> (ø)
explorer/rest/rest/model/Mosaic.py 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant