Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multisig search #251

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Multisig search #251

wants to merge 3 commits into from

Conversation

fboucquez
Copy link
Contributor

No description provided.

@fboucquez fboucquez requested a review from rg911 November 30, 2020 00:08
segfaultxavi
segfaultxavi requested changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@segfaultxavi segfaultxavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Multisig" is a weird word 😁

spec/plugins/multisig/routes/searchAccountMultisigs.yml Outdated Show resolved Hide resolved
spec/plugins/multisig/schemas/MultisigPage.yml Outdated Show resolved Hide resolved
rg911
rg911 reviewed Nov 30, 2020
View reviewed changes
Copy link
Contributor

@rg911 rg911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need a searcher for multisig at all?

@fboucquez
Copy link
Contributor Author

The search capability? it will help us at least with the state proof. We will be able to integrate over all mulsigi states and run the merkle proof.

@rg911
Copy link
Contributor

rg911 commented Nov 30, 2020

The search capability? it will help us at least with the state proof. We will be able to integrate over all mulsigi states and run the merkle proof.

Not sure how it will help the merkle proof tbh. State proof should only take the multisig acount's address??

@fboucquez
Copy link
Contributor Author

But how efficiently do you know all the multisig in the system? We have that way for all other entities but the multisig.
We can also filter by cosignaure address which I think it would be nice for the users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rg911 rg911 rg911 left review comments

@segfaultxavi segfaultxavi segfaultxavi requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fboucquez @rg911 @segfaultxavi