Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync classes #22

Merged
merged 5 commits into from
Jul 21, 2024
Merged

Sync classes #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
25e1c9f
Sync classes
tfirdaus Jun 30, 2024
e0ffb45
Fix PHPCS violations
tfirdaus Jul 21, 2024
d9e64b4
Update PHP & WP version tests
tfirdaus Jul 21, 2024
c149449
Update composer installation
tfirdaus Jul 21, 2024
cb3b8fe
Update deps installations
tfirdaus Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ jobs:
strategy:
fail-fast: true
matrix:
php: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
php: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
wp: ['5.*', '6.5'] # WordPress 6.6 requires 7.2.

env:
WP_DB_TEST_NAME: wp_test
Expand Down Expand Up @@ -114,6 +115,7 @@ jobs:

- name: Install dependencies
run: |
composer require "wp-phpunit/wp-phpunit:${{ matrix.wp }}" "roots/wordpress:${{ matrix.wp }}" --no-interaction --no-update --dev
composer remove syntatis/coding-standard rector/rector --dev
composer install --prefer-dist

Expand Down
2 changes: 1 addition & 1 deletion app/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,7 @@ protected function sanitize_requires_version($version)
// x.y or x.y.z
! preg_match('!^\d+\.\d(\.\d+)?$!', $version) ||
// Allow plugins to mark themselves as requireing Stable+0.1 (trunk/master) but not higher
( defined('WP_CORE_STABLE_BRANCH') && ( (float) $version > (float) WP_CORE_STABLE_BRANCH + 0.1 ) )
defined('WP_CORE_STABLE_BRANCH') && ( (float) $version > (float) WP_CORE_STABLE_BRANCH + 0.1 )
) {
$this->warnings['requires_header_ignored'] = true;
// Ignore the readme value.
Expand Down
7 changes: 5 additions & 2 deletions phpcs.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
<!-- Show the warning but exit with 0. The Warning is fine -->
<config name="ignore_warnings_on_exit" value="1"/>

<!-- Check for cross-version support for PHP 7.2 or higher. Requires PHPCompatibility -->
<config name="testVersion" value="7.2-"/>
<!-- Check for cross-version support for PHP 7.0 or higher. Requires PHPCompatibility -->
<config name="testVersion" value="7.0-"/>

<!-- Include full Doctrine Coding Standard -->
<rule ref="Syntatis"/>
Expand All @@ -42,6 +42,9 @@
<rule ref="Generic.PHP.ForbiddenFunctions">
<exclude name="Generic.PHP.ForbiddenFunctions.Found"/>
</rule>
<rule ref="Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence">
<exclude name="Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence.MissingParentheses"/>
</rule>
<rule ref="Squiz.NamingConventions.ValidVariableName">
<exclude name="Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps"/>
<exclude name="Squiz.NamingConventions.ValidVariableName.NotCamelCaps"/>
Expand Down