Dev 4.x #59
Open
Dev 4.x #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it was done in this way because the project cannot be directly joined to perform a pull request, due to project life cycle nonconformity
…it was done in this way because the project cannot be directly joined to perform a pull request, due to project life cycle nonconformity
einalex
reviewed
Apr 8, 2021
| @@ -1,11 +0,0 @@ | |||
| REACT_APP_VERSION=$npm_package_version | |||
| REACT_APP_NAME=$npm_package_name | |||
| REACT_APP_FIREBASE_KEY=AIzaSyBT7D0KjQgOu5C2cfJ1zTrk7G1GXHvHJSc | |||
There was a problem hiding this comment.
This doesn't fix the problem. The keys are still in git history and so they're still public.
There was a problem hiding this comment.
Should make sure whatever keys that are being used are different
einalex
reviewed
Apr 8, 2021
einalex
reviewed
Apr 8, 2021
einalex
reviewed
Apr 8, 2021
einalex
reviewed
Apr 13, 2021
| To register your masternodes, go to https://syshub.org and sign up. | ||
| - Go to MASTERNODE SETTINGS and enter the required masternode details using the form -OR- | ||
| - Go to MULTIPLE ADD, copy the contents of your masternode.conf file in the box and push ADD ALL. This will register ALL your msternodes automatically. | ||
|
|
||
| # Developed by Syscoin Development and Marketing Team |
There was a problem hiding this comment.
a team with that name doesn't exist, needs adjusting.
einalex
reviewed
Apr 13, 2021
| @@ -0,0 +1,29 @@ | |||
| --- | |||
There was a problem hiding this comment.
maybe I'm wrong, but shouldn't other projects, that are being used, be pulled in dynamically by whatever builds the website rather than being checked into version control?
einalex
reviewed
Apr 13, 2021
| @@ -0,0 +1,15 @@ | |||
| .DS_Store | |||
There was a problem hiding this comment.
and if pulling them in is not possible and they are git projects, please use git submodules.
sidhujag
requested changes
May 3, 2021
sidhujag
requested changes
May 3, 2021
sidhujag
reviewed
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.