Refine code generation for address-of operations #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
changed the title
The instruction sequences of address-of and global address-of operations are similar but differ only in the register used for certain instructions. The situation occurs for ARM and RISC-V backends. Thus, this commit adjusts the backend implementation to reuse a unified code path when generating instructions for 'address of' operations.
DrXiao
force-pushed
the
refine-codegen
branch
from
3ba2bf5
to
418d20e
Compare
nosba0957
approved these changes
Nov 26, 2024
|
Thank @DrXiao for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon further observation, I noticed that the instruction sequences of address-of and global address-of are highly similar and can be refined.
The proposed changes resemble my previous pull request (#167), but were discovered later, which is why I am submitting this pull request for improvement.