Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #29

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Improve documentation #29

merged 1 commit into from
Nov 11, 2024

Conversation

felipecrs
Copy link
Contributor

Thank you very much for your project. It is of great help to me.

Just wanted to contribute back some realizations I had when I was trying this custom component for the first time.

I may seem silly, but I honestly thought the factory_reset would in fact reset the ESPHome device to factory settings for some reason. More clarification is never a bad thing, I'd say.

@felipecrs
Copy link
Contributor Author

I cannot confirm this theory, but I believe the DL-F ones may be the ones which have Wi-Fi built-in like mine:

image

@syssi
Copy link
Owner

syssi commented Nov 11, 2024

Do you like to extend the list of supported devices by your model?

@felipecrs
Copy link
Contributor Author

felipecrs commented Nov 11, 2024

It's this one:

https://aliexpress.com/item/1005007159871684.html

It's printed 8S24V100A in its shell, which I honestly don't know if it's the model number. It seems generic enough to be shared by other BMSes. But I know it's K Series.

And the docs already say:

  • Daly Smart BMS K Series 100A

That's why I just extended this line to mention my BLE advertised name.

@felipecrs
Copy link
Contributor Author

What do you think? Feel free to patch this PR if you want.

@syssi syssi merged commit 3e81c69 into syssi:main Nov 11, 2024
6 checks passed
@felipecrs felipecrs deleted the improve-documentation branch November 11, 2024 21:45
@syssi
Copy link
Owner

syssi commented Nov 11, 2024

I wasn't aware of the fact your series is already mentioned as supported. I expected a different series.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants