Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @emotion/react to peerDependencies #2366

Closed

Conversation

ckeeney
Copy link

@ckeeney ckeeney commented Nov 21, 2022

adds

  "peerDependencies": {
    "@emotion/react": "^11"
  },

to package.json.

Resolves #2198

@vercel
Copy link

vercel bot commented Nov 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
theme-ui ❌ Failed (Inspect) Nov 21, 2022 at 10:47AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8447173:

Sandbox Source
next-theme-ui-example Configuration
gatsby-plugin-theme-ui-example Configuration

@lachlanjc
Copy link
Member

Hmm, when I pnpm i locally:
CleanShot 2022-11-21 at 23 40 53@2x

Copy link
Member

@hasparus hasparus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ckeeney. Thank you for your interest in Theme UI.

You've added a peer dependency to workspace root package.json, which is a private package.
It contains the dependencies and scripts used to maintain the library.

If you're looking for one of theme-ui's proper package.json files, you can find them in packages/ directory.

However, I must say sorry — I shouldn't have labeled #2198 as good first issue — the work to do here is a bit more complex than modifying peerDependencies in a package.json. To close the issue, we'd need a TypeScript or Bash script, a GitHub action step that would verify we're installing without errors.

@hasparus hasparus closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure all transitive peerDependencies are listed correctly and test Yarn 2/3 installs
3 participants