Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some opts to be more consistent #3201

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

NekkoDroid
Copy link
Contributor

@NekkoDroid NekkoDroid commented Nov 16, 2024

Just noticed some directory long opts used dir= while others used directory=, should all now be consistently directory=.

Copy link
Contributor

@behrmann behrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the longer name a bit better and changing it from -directory to -dir leaves the --directory option, but it's still more consistent than the status quo.

@NekkoDroid
Copy link
Contributor Author

NekkoDroid commented Nov 17, 2024

I am also fine with changing them all to use the longer *-directory=, just the shorter form is used more often current, so I went with that.

@behrmann
Copy link
Contributor

Let's have @DaanDeMeyer weigh in, since he just added another. Either way this PR will need a rebase.

@NekkoDroid NekkoDroid force-pushed the opt-names branch 2 times, most recently from 464ad4b to b450eb5 Compare November 18, 2024 16:52
@NekkoDroid
Copy link
Contributor Author

Changed them to the longer *-directory=. I think I got most of them all with the exception of --wipe-build-dir as that (from what I see) doesn't have a way to keep backwards compat.

@DaanDeMeyer DaanDeMeyer merged commit 0b4adac into systemd:main Nov 18, 2024
30 of 36 checks passed
@NekkoDroid NekkoDroid deleted the opt-names branch November 18, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants