feat(si): Ensure we capture the name of the containe engine when trac…

…king usage
systeminit · Aug 23, 2023 · e6fac8a · e6fac8a
1 parent 8a42363
commit e6fac8a
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 0 deletions.
diff --git a/lib/si-cli/src/engine.rs b/lib/si-cli/src/engine.rs
@@ -8,6 +8,7 @@ pub mod podman_engine;
 
 #[async_trait]
 pub trait ContainerEngine {
+    fn get_engine_identifier(&self) -> String;
     async fn ping(&self) -> CliResult<()>;
     async fn missing_containers(&self) -> Result<Vec<String>, SiCliError>;
     async fn download_missing_containers(&self, missing_containers: Vec<String>) -> CliResult<()>;

diff --git a/lib/si-cli/src/engine/docker_engine.rs b/lib/si-cli/src/engine/docker_engine.rs
@@ -57,6 +57,10 @@ impl DockerEngine {
 
 #[async_trait]
 impl ContainerEngine for DockerEngine {
+    fn get_engine_identifier(&self) -> String {
+        "docker".to_string()
+    }
+
     async fn ping(&self) -> CliResult<()> {
         self.docker.ping().await?;
         Ok(())

diff --git a/lib/si-cli/src/engine/podman_engine.rs b/lib/si-cli/src/engine/podman_engine.rs
@@ -18,6 +18,10 @@ impl PodmanEngine {
 
 #[async_trait]
 impl ContainerEngine for PodmanEngine {
+    fn get_engine_identifier(&self) -> String {
+        "podman".to_string()
+    }
+
     async fn ping(&self) -> CliResult<()> {
         let ping_info = self.podman.ping().await?;
         dbg!(&ping_info);

diff --git a/lib/si-cli/src/state.rs b/lib/si-cli/src/state.rs
@@ -91,6 +91,10 @@ impl AppState {
         prop_map.insert("mode".to_string(), serde_json::json!(self.mode()));
         prop_map.insert("os".to_string(), serde_json::json!(env::consts::OS));
         prop_map.insert("arch".to_string(), serde_json::json!(env::consts::ARCH));
+        prop_map.insert(
+            "container_engine".to_string(),
+            serde_json::json!(self.container_engine().get_engine_identifier()),
+        );
 
         ph_client
             .capture("si-command", distinct_id, properties)