WIP: allow multiple videobridges #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murme1
commented
Mar 9, 2021
| - jitsi-meet-prosody | ||
| - jitsi-meet-web | ||
| - jitsi-meet-web-config | ||
| jitsi_meet_apt_repositories_pin_packages: "{{ ['jitsi-videobridge2'] + (jitsi_meet_single_instance | ternary(_jitsi_meet_apt_repositories_pin_packages, [])) }}" |
There was a problem hiding this comment.
This is ugly, but works.
|
Thank you for permitting this PR. I think we shouldn't refactor that much. Instead of moving everything in subfolders, make videobridge an independent role that can work on it's own and can be tested independently. Afterwards, make videobridge a conditional dependency of jitsit-meet in |
|
Hello, as you might have guessed by my absence, i don't have the time to put more work into this, right now. I will close this PR for now and might come back to it later. Feel free to use my code, if you plan to tackle the multi videobridge setup yourself in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP draft for configuring multiple videobridges with this role.
Most definitely missing are:
In my tests, these changes were backwards compatible, as long as one did not change the name of the role to something else then
jitsi-meet(since that would break the galaxy dependencies inmeta/main.yml).Be aware that i'm using a custom version of this branch with some customizations specific to my own setup, so i never tested this code as is. That should probably happen, before merging.. :)
Fixes #53.