Fix broken upgrade process using custom apps #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappor0
changed the title
doobry-systemli
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom apps functionality was previously broken when upgrading:
The apps taskfile which was also used to enable custom apps was run in the upgrade taskfile which meant that the custom app was not found at this point.
The change in logic is thus: enable only the custom apps after they were copied. Custom apps should no longer be listed in the
nextcloud_appsvar.Another possible solution would be to move the copying of the custom apps into the apps taskfile. TBH I don't quite understand enough of how all this works to get this to work.