German patch 1 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjustments have been made to fit better into the text boxes. In some cases synonyms were used. Umlauts have been added again for the most part.
|
I cannot accept this pull request as you probably have not tested it in SoulFu. I suspect it because you introduced umlauts in each string without actually seeing them in the game. The game uses two fonts - black one is used in bubbles (like in quotes or in fortune cookie texts), the other one is used in game as button or hint text. The black font supports only pure ASCII characters (no umlauts or Eszett), the other font supports umlauts but still no Eszett (at least for now). I suggest testing your translation in every possible context, including Rogue book (named BOOK 1), quotes and fortune cookie strings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustments have been made to fit better into the text boxes. In some cases synonyms were used. Umlauts have been added again for the most part.