M3 Trip Create/Edit #25
Merged
+3,037
−304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuraikun
reviewed
Jan 18, 2024
|
@Kana-TAGUCHI Let tell me the reason why doesn't image form upload and preview a file in this PR?
|
|
@samuraikun |
SachiGoto
reviewed
Jan 21, 2024
kanatagu
commented
Jan 31, 2024
| @@ -0,0 +1,106 @@ | |||
| import DatePicker from 'react-datepicker' | |||
There was a problem hiding this comment.
You see a warning but this is depending on DatePicker library...
Comment on lines
+3
to
+8
| /* | ||
| * NOTE: This timezone is used for the entire application. | ||
| * All form inputs for date or date time should have offset of +09:00 e.g."2024-01-01T00:00:00+09:00", which is Tokyo timezone. | ||
| * See "formatToISODate" function. | ||
| */ | ||
| const TIMEZONE = 'Asia/Tokyo' |
There was a problem hiding this comment.
This is important for this application so I added NOTE
| <FormErrorMessage>{errors?.date_to?.message}</FormErrorMessage> | ||
| </FormControl> | ||
|
|
||
| {/* TODO Image Upload to storage & Send the URL string to DB */} |
There was a problem hiding this comment.
Image will be implemented later after Koji's PR is merged!
samuraikun
reviewed
Jan 31, 2024
samuraikun
approved these changes
Jan 31, 2024
SachiGoto
approved these changes
Feb 1, 2024
|
@samuraikun 
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE
If you want to check in local environment, please change the backend branch to tabi-memo/backend#18 first, then reset and seed.
Fixes # (issue)
#20
Type of change
Check List
URL
Create page: http://localhost:3000/trip/create
Edit Page (ex) : http://localhost:3000/trip/50370a01-879a-4e46-bda7-70e2022241cb/edit
Screen Recording
Create
Screen.Recording.2024-01-30.at.9.08.11.PM.mov
Edit
https://github.com/tabi-memo/frontend/assets/66394413/b8ef5549-2a84-4dc4-b487-6bb597b111d8