Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common components (Header, Footer, Link) #4

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

kanatagu
Copy link
Contributor

@kanatagu kanatagu commented Nov 23, 2023

Description

  • Added common components (Header, Footer, Link)
  • You can change dark mode/light mode too
  • Added an Issue Storybook with Next Image #5, which we want to fix when we have time

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshot

screencapture-localhost-3000-2023-11-22-23_59_42

screencapture-localhost-3000-2023-11-22-23_59_52

@@ -0,0 +1,51 @@
import React from 'react'
import { Link as NextLink } from '@chakra-ui/next-js'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package provides the Link which combines the functionality of the Next.js Link and Chakra UI Link components.
https://chakra-ui.com/getting-started/nextjs-guide#chakra-ui-with-nextjs-link

👍

Copy link
Contributor

@samuraikun samuraikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanatagu kanatagu merged commit 24ea770 into main Nov 24, 2023
1 check passed
@kanatagu kanatagu deleted the common_components branch November 24, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants