Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix activity test #40

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Fix activity test #40

merged 1 commit into from
Mar 10, 2024

Conversation

kanatagu
Copy link
Contributor

@kanatagu kanatagu commented Mar 8, 2024 •
edited
Loading

Description

  • Fixed activity test
  • The Activity tab was correct. The seed data was 2021, and I tried to add the data 2024 at that time. That's why it looked not correct. I changed seed data : Change the year of seed data backend#22

Fixes # (issue)
#39

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Check List

URL

Screenshot

@kanatagu kanatagu self-assigned this Mar 8, 2024
kanatagu
kanatagu commented Mar 8, 2024
View reviewed changes
jest.config.ts
@@ -25,21 +25,21 @@ const config: Config = {
clearMocks: true,

// Indicates whether the coverage information should be collected while executing the test
collectCoverage: true,
collectCoverage: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need coverage

@kanatagu kanatagu requested a review from samuraikun March 8, 2024 06:47
samuraikun
samuraikun approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@samuraikun samuraikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍎

@samuraikun samuraikun merged commit 266d651 into main Mar 10, 2024
2 checks passed
@samuraikun samuraikun deleted the fix/activity_test branch March 10, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuraikun samuraikun samuraikun approved these changes

Assignees

@kanatagu kanatagu

Labels
Review Required 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanatagu @samuraikun